-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add support to PANDAS_GBQ_CREDENTIALS_FILE (#86) #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
===========================================
- Coverage 73.61% 28.21% -45.41%
===========================================
Files 4 4
Lines 1554 1563 +9
===========================================
- Hits 1144 441 -703
- Misses 410 1122 +712
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonathansp ! Please could you also create an entry in the changelog? https://github.com/pydata/pandas-gbq/blob/master/docs/source/changelog.rst
As an example,
- Environment variable ``PANDAS_GBQ_CREDENTIALS_FILE`` can now be used to override the default location where the BigQuery user account credentials are stored. (:issue:`86`)
pandas_gbq/gbq.py
Outdated
getting user credentials. | ||
getting user credentials. A file named bigquery_credentials.dat will | ||
be created in current dir. You can also set PANDAS_GBQ_CREDENTIALS_FILE | ||
environment variable so as to define a specific path to storage this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storage->store
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonathansp !
Thanks, @parthea, we really appreciate your work. Do you have a release plan for this change? |
|
@jonathansp I'm hoping to create a new release once #83 is merged (pending approval). It would be great to get your feedback on that PR. In the interim while we are preparing for the next release, you could install the latest master using: |
No description provided.